[PATCH] D125248: [instcombine] Propagate freeze back to def

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:33:16 PDT 2022


mtrofin abandoned this revision.
mtrofin added a comment.

In D125248#3503741 <https://reviews.llvm.org/D125248#3503741>, @nikic wrote:

> I've put up https://reviews.llvm.org/D125321, which extends freezeDominatedUses() to move the freeze such that it dominates all uses (if possible).

Yup, thanks!. I'm not super sure why we'd want to insert the new freeze first (potentially) in the middle of the original's uses, then hoist it to dominate all uses (rather than place it "at the right place" upfront), but likely I'm missing some design nuance of this pass. I'm not hung up on this - asking to learn.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125248/new/

https://reviews.llvm.org/D125248



More information about the llvm-commits mailing list