[PATCH] D125321: [InstCombine] Freeze other uses of frozen value

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:26:34 PDT 2022


mtrofin added a comment.

could you also add the test from D125248 <https://reviews.llvm.org/D125248> - can't hurt to have more.



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3816
 
-  bool Changed = false;
+  // Find the nearest common dominator of all uses of Op.
+  Instruction *Dom = nullptr;
----------------
wouldn't going to the def of `Op` be sufficient and compile-time cheaper?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125321/new/

https://reviews.llvm.org/D125321



More information about the llvm-commits mailing list