[PATCH] D125158: [DirectX backend] Add pass to emit dxil metadata.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:63
+
+namespace {
+class DXILTranslateMetadata : public ModulePass {
----------------
kuhar wrote:
> beanz wrote:
> > kuhar wrote:
> > > You can open this namespace higher up so that you don't need to annotate each function with static
> > not to nitpick, but that comment contradicts the coding standards, and is the opposite of the feedback I provided :)
> > 
> > see: https://www.llvm.org/docs/CodingStandards.html#anonymous-namespaces
> TIL, I thought that the guideline was the inverse. Thanks, @beanz.
I literally made the same mistake like two weeks ago (hence having the link handy) 😄 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125158/new/

https://reviews.llvm.org/D125158