[PATCH] D124825: [LoongArch] Check msb is not less than lsb for the bstr{ins/pick}.{w/d} instructions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:19:40 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/LoongArch/Basic/Integer/invalid.s:190
+# CHECK: :[[#@LINE+1]]:22: error: msb is less than lsb
+bstrpick.w $a0, $a0, 1, 2
+# CHECK:             ^~~~
----------------
Perhaps pick a different set as `1 < 2` has been covered by the previous instruction.


================
Comment at: llvm/test/MC/LoongArch/Basic/Integer/invalid64.s:74
+# CHECK: :[[#@LINE+1]]:22: error: msb is less than lsb
+bstrpick.d $a0, $a0, 1, 2
+# CHECK:             ^~~~
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124825/new/

https://reviews.llvm.org/D124825



More information about the llvm-commits mailing list