[PATCH] D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

LGTM but please get another one before submitting



================
Comment at: llvm/lib/Target/DirectX/DXILOpLowering.cpp:121
+    return ST->getStructName().str();
+  } else {
+    std::string Str;
----------------
nit: no else after return: https://www.llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124805/new/

https://reviews.llvm.org/D124805