[PATCH] D125207: [BPF] Implement mod operation
Yonghong Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 10 09:02:04 PDT 2022
yonghong-song added a comment.
The current 'summary' or commit message is too simple. Could you clarify some motivation why you need to add this instruction?
The change itself looks good to me. The kernel selftest test_verifier does test BPF_MOD instruction and I checked verifier code, BPF_MOD is handled similar to BPF_DIV which should be okay in most cases, so I didn't see a major issue here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125207/new/
https://reviews.llvm.org/D125207
More information about the llvm-commits
mailing list