[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

Tue May 10 07:44:49 PDT 2022

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

In D125203#3502651 <https://reviews.llvm.org/D125203#3502651>, @tingwang wrote:

> In D125203#3502433 <https://reviews.llvm.org/D125203#3502433>, @nemanjai wrote:
>
>> Why not also fix this in the front end so that we allow the builtin on the A2 CPU as well (since it's supported)?
>
> Oh I missed that. Thank you for pointing out!
>
> Just now updated the patch. However I didn't update the SemaFeatureCheck message to indicate the support on a2, since if people see this error message, it cannot be a2, and a2 does not easily fit into the message of err_ppc_builtin_only_on_arch. Hope this will not create problem.

I wouldn't worry about it. If we have to change this in the future because some implementation of the ISA that isn't `pwr<N>` needs to reference it, we can change it at that time.

LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125203/new/

https://reviews.llvm.org/D125203