[PATCH] D125273: [llvm-ml] Imlement support for MASM's extern directive

[Eric Astor via Phabricator via llvm-commits]

epastor accepted this revision.
epastor added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-ml/extern.asm:4
+
+extern foo : dword, bar : word
+
----------------
If feasible, we should test that the type info works correctly too - possibly by checking that they work in the appropriate contexts and fail in the appropriate contexts?

Just off the top of my head (and I may have this wrong, I didn't check)... I think:

mov ebx, foo
mov bx, bar

should both work, but

mov bx, foo
mov bl, bar

should both fail due to size checking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125273/new/

https://reviews.llvm.org/D125273