[PATCH] D125261: [AMDGPU] gfx11 subtarget features & early tests

Tue May 10 07:06:39 PDT 2022

Joe_Nash marked 5 inline comments as done.
Joe_Nash added a comment.

In D125261#3503213 <https://reviews.llvm.org/D125261#3503213>, @foad wrote:

>> Contributors:
>> Jay Foad <jay.foad at amd.com>
>
> Please don't feel obliged to credit me (unless you feel it's important for the historical record).

I appreciate that. It is not a big burden, I'm just making a best effort basis to give some credit. If you explicitly DON'T want to be there I can of course remove it.

In D125261#3503333 <https://reviews.llvm.org/D125261#3503333>, @Petar.Avramovic wrote:

> Can you also add comment that test changes for some memory instructions are caused by subtarget feature that allows offset folding (to be precise not having feature that forbids offset folding). Maybe separate these tests to another patch.

Added a your suggested comment.

================
Comment at: llvm/lib/Target/AMDGPU/GCNSubtarget.h:708-709

+  bool hasDot8Insts() const { return HasDot8Insts; }
+
   bool hasMAIInsts() const {
----------------
Petar.Avramovic wrote:
> Can you use same line break as above? clang-format did this probably.
Yep, clang-format. I am never quite sure whether to match existing style or unify on clang-format. I'll match existing in this case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125261/new/

https://reviews.llvm.org/D125261