[PATCH] D125303: [update_llc_test_checks] Handle mixed asm and ISel debug output

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 04:04:36 PDT 2022


arichardson created this revision.
arichardson added reviewers: ningxinr, sebastian-ne, Flakebi.
Herald added a project: All.
arichardson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I noticed a potentially uninitialized variable warning after D119368 <https://reviews.llvm.org/D119368>.
While this is a false(-ish) positive warning, it did highlight that the
output_type variable was being set based on the last RUN line, so mixed
ISel and ASM checks will not work. This commit allows mixed ISel and ASM
output and also fixes the IntelliJ warning. I have deleted the
add_checks() function from isel.py as it is identical to the one in asm.py
and restored the old name (which fixes the formatting too).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125303

Files:
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_isel.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86_isel.ll.expected
  llvm/utils/UpdateTestChecks/asm.py
  llvm/utils/UpdateTestChecks/isel.py
  llvm/utils/update_cc_test_checks.py
  llvm/utils/update_llc_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125303.428333.patch
Type: text/x-patch
Size: 7709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220510/b3788ebc/attachment.bin>


More information about the llvm-commits mailing list