[PATCH] D125083: [RISCV] Use check-prefixes to reduce check lines

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.
Herald added a subscriber: shiva0217.


================
Comment at: llvm/test/CodeGen/RISCV/float-isnan.ll:3
 ; RUN: llc -mtriple=riscv32 -mattr=+f -target-abi ilp32f -verify-machineinstrs \
-; RUN:   < %s | FileCheck -check-prefix=RV32IF %s
+; RUN:   < %s | FileCheck -check-prefixes=CHECK %s
 ; RUN: llc -mtriple=riscv64 -mattr=+f -target-abi lp64f -verify-machineinstrs \
----------------
`--check-prefixes=CHECK` is redundant


================
Comment at: llvm/test/CodeGen/RISCV/float-isnan.ll:8
 define zeroext i1 @float_is_nan(float %a) nounwind {
 ; RV32IF-LABEL: float_is_nan:
 ; RV32IF:       # %bb.0:
----------------
These dead check prefixes can be removed


================
Comment at: llvm/test/CodeGen/RISCV/float-select-fcmp.ll:3
 ; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN:   -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN:   -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIF %s
 ; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
Why's this `CHECKIF` and not `CHECK`?


================
Comment at: llvm/test/CodeGen/RISCV/float-select-fcmp.ll:8
 define float @select_fcmp_false(float %a, float %b) nounwind {
 ; RV32IF-LABEL: select_fcmp_false:
 ; RV32IF:       # %bb.0:
----------------
Dead check prefixes here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125083/new/

https://reviews.llvm.org/D125083