[PATCH] D125289: [RISCV] Remove some TODOs in tests

[Shao-Ce SUN via Phabricator via llvm-commits]

sunshaoce created this revision.
sunshaoce added reviewers: asb, benshi001, craig.topper, eopXD, frasercrmck.
Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
sunshaoce requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125289

Files:
  llvm/test/CodeGen/RISCV/double-br-fcmp.ll
  llvm/test/CodeGen/RISCV/float-br-fcmp.ll
  llvm/test/CodeGen/RISCV/half-br-fcmp.ll
  llvm/test/MC/RISCV/rvd-aliases-valid.s
  llvm/test/MC/RISCV/rvf-aliases-valid.s


Index: llvm/test/MC/RISCV/rvf-aliases-valid.s
===================================================================
--- llvm/test/MC/RISCV/rvf-aliases-valid.s
+++ llvm/test/MC/RISCV/rvf-aliases-valid.s
@@ -23,8 +23,12 @@
 ## Assembler Pseudo Instructions (User-Level ISA, Version 2.2, Chapter 20)
 ##===----------------------------------------------------------------------===##
 
-# TODO flw
-# TODO fsw
+# CHECK-INST: flw ft0, 0(a0)
+# CHECK-ALIAS:  flw ft0, 0(a0)
+flw f0, (a0)
+# CHECK-INST: fsw ft0, 0(a0)
+# CHECK-ALIAS: fsw ft0, 0(a0)
+fsw f0, (a0)
 
 # CHECK-INST: fsgnj.s ft0, ft1, ft1
 # CHECK-ALIAS: fmv.s ft0, ft1
Index: llvm/test/MC/RISCV/rvd-aliases-valid.s
===================================================================
--- llvm/test/MC/RISCV/rvd-aliases-valid.s
+++ llvm/test/MC/RISCV/rvd-aliases-valid.s
@@ -23,8 +23,12 @@
 ## Assembler Pseudo Instructions (User-Level ISA, Version 2.2, Chapter 20)
 ##===----------------------------------------------------------------------===##
 
-# TODO fld
-# TODO fsd
+# CHECK-INST: fld ft0, 0(a0)
+# CHECK-ALIAS:  fld ft0, 0(a0)
+fld f0, (a0)
+# CHECK-INST: fsd ft0, 0(a0)
+# CHECK-ALIAS: fsd ft0, 0(a0)
+fsd f0, (a0)
 
 # CHECK-INST: fsgnj.d ft0, ft1, ft1
 # CHECK-ALIAS: fmv.d ft0, ft1
Index: llvm/test/CodeGen/RISCV/half-br-fcmp.ll
===================================================================
--- llvm/test/CodeGen/RISCV/half-br-fcmp.ll
+++ llvm/test/CodeGen/RISCV/half-br-fcmp.ll
@@ -549,7 +549,7 @@
 }
 
 define void @br_fcmp_uno(half %a, half %b) nounwind {
-; TODO: sltiu+bne -> beq
+
 ; RV32IZFH-LABEL: br_fcmp_uno:
 ; RV32IZFH:       # %bb.0:
 ; RV32IZFH-NEXT:    addi sp, sp, -16
Index: llvm/test/CodeGen/RISCV/float-br-fcmp.ll
===================================================================
--- llvm/test/CodeGen/RISCV/float-br-fcmp.ll
+++ llvm/test/CodeGen/RISCV/float-br-fcmp.ll
@@ -549,7 +549,6 @@
 }
 
 define void @br_fcmp_uno(float %a, float %b) nounwind {
-; TODO: sltiu+bne -> beq
 ; RV32IF-LABEL: br_fcmp_uno:
 ; RV32IF:       # %bb.0:
 ; RV32IF-NEXT:    addi sp, sp, -16
@@ -626,7 +625,6 @@
 ; This test exists primarily to trigger RISCVInstrInfo::storeRegToStackSlot
 ; and RISCVInstrInfo::loadRegFromStackSlot
 define i32 @br_fcmp_store_load_stack_slot(float %a, float %b) nounwind {
-; TODO: addi %lo(.LCPI17_0) should be merged in to the following flw
 ; RV32IF-LABEL: br_fcmp_store_load_stack_slot:
 ; RV32IF:       # %bb.0: # %entry
 ; RV32IF-NEXT:    addi sp, sp, -16
Index: llvm/test/CodeGen/RISCV/double-br-fcmp.ll
===================================================================
--- llvm/test/CodeGen/RISCV/double-br-fcmp.ll
+++ llvm/test/CodeGen/RISCV/double-br-fcmp.ll
@@ -548,7 +548,6 @@
 }
 
 define void @br_fcmp_uno(double %a, double %b) nounwind {
-; TODO: sltiu+bne -> beq
 ; RV32IFD-LABEL: br_fcmp_uno:
 ; RV32IFD:       # %bb.0:
 ; RV32IFD-NEXT:    addi sp, sp, -16


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125289.428290.patch
Type: text/x-patch
Size: 2881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220510/64b2ccab/attachment.bin>