[PATCH] D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks

Ten Tzen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 18:10:02 PDT 2022


tentzen added a comment.

> This isn't really the distinction I'm trying making here.  The distinction here is between LLVM IR uses of blockaddress (for indirectbr), and MachineFunction uses of MachineBasicBlock labels (for retpoline etc.).    Jump tables would fall into the latter category, except that we have explicit code to update jump tables in the places where it would matter.

OK. How about IRBlockAddressTaken and MachineBlockAddressTaken.  I think having "AddressTaken" explicitly spelled out here can avoid future confusions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124697/new/

https://reviews.llvm.org/D124697



More information about the llvm-commits mailing list