[PATCH] D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function.

[Xiang Li via Phabricator via llvm-commits]

python3kgae added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILOpLowering.cpp:33
+
+enum OverloadKind : uint16_t {
+  VOID = 1,
----------------
kuhar wrote:
> nit: prefer `enum class`
enum class will require cast on case like OverloadKind::FLOAT | OverloadKind::HALF.
I prefer not to have
(uint16_t)OverloadKind::FLOAT | (uint16_t)OverloadKind::HALF.

Is it OK to keep it without enum class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124805/new/

https://reviews.llvm.org/D124805