[PATCH] D125277: [TableGen] Refactor TableGenParseFile to no longer use a callback

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 15:33:26 PDT 2022


rriddle created this revision.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, mehdi_amini, bollu, hiraditya.
Herald added a project: All.
rriddle requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added projects: MLIR, LLVM.

Now that TableGen no longer relies on global Record state, we can allow
for the client to own the RecordKeeper and SourceMgr. Given that TableGen
internally still relies on the global llvm::SrcMgr, this method unfortunately
still isn't thread-safe.

Depends on D125276 <https://reviews.llvm.org/D125276>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125277

Files:
  llvm/include/llvm/TableGen/Parser.h
  llvm/lib/TableGen/Parser.cpp
  llvm/unittests/TableGen/ParserEntryPointTest.cpp
  mlir/lib/Tools/PDLL/Parser/Parser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125277.428221.patch
Type: text/x-patch
Size: 7811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220509/9e5d585c/attachment.bin>


More information about the llvm-commits mailing list