[PATCH] D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ErrorHandling.h:57
+  double P = static_cast<double>(Num) * 100 / Total;
+  if (P < WarningSummaryThres)
+    return;
----------------
Use <= ?


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:46
 
+cl::opt<int> WarningSummaryThres(
+    "warning-summary-threshold", llvm::cl::init(5),
----------------
nit: use unsigned int

Wondering what's a good place to do the validation. It should be within [1,100].


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125255/new/

https://reviews.llvm.org/D125255