[PATCH] D125247: [ValueTypes] Define MVTs for v128i2/v64i4 as well as i2 and i4.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/Support/MachineValueType.h:288
       // This value must be a multiple of 32.
       MAX_ALLOWED_VALUETYPE = 192,
 
----------------
jrtc27 wrote:
> We're starting to creep awfully close to this. Downstream we have 5 extra MVTs (though could get away with just 3), and Arm's Morello fork of CHERI LLVM adds another one (but we should really have more than one were we to have it in CHERI LLVM). Is there a plan for what to do when this limit finally gets hit? Because the slow but steady explosion of vector types is causing me some amount of worry for us downstream...
We can add 32 to it. I think we can bump it all the way to 256 without issue. It's used to reduce the size of some tables in TargetLowering. Bumping it only increases the size of those tables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125247/new/

https://reviews.llvm.org/D125247