[llvm] 5afd208 - [riscv] Mark function as used to avoid unused warning.
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Mon May 9 14:33:44 PDT 2022
Forgot to say, I definitely see value in the needVSETVLI(CurInfo, MI)
variant. If you wanted to land that on it's own, LGTM.
I now have all of my planned patches posted. The last one turned out to
be a lot more nasty than expected; if you have ideas there, let me know.
I'm almost wondering if we want phase 1 to do the mutation transforms,
before computing the dataflow. That would be a bit weird, but it might
be less complex than my current scheme. Thoughts?
Philip
On 5/9/22 11:19, Philip Reames wrote:
>
> Idiomatic LLVM_DEBUG dbgs(). (Added in later patches.)
>
> Philip
>
> On 5/9/22 10:56, David Blaikie via llvm-commits wrote:
>
>> Any idea why this function exists? Usually users would be expected to
>> use dump functions, not op<<, yeah?
>>
>> On Tue, May 3, 2022 at 6:59 PM via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>
>>
>> Author: Weverything
>> Date: 2022-05-03T18:51:23-07:00
>> New Revision: 5afd20806d4e28e5d8a8f968f199a663021bbb5b
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/5afd20806d4e28e5d8a8f968f199a663021bbb5b
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/5afd20806d4e28e5d8a8f968f199a663021bbb5b.diff
>>
>> LOG: [riscv] Mark function as used to avoid unused warning.
>>
>> Added:
>>
>>
>> Modified:
>> llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
>>
>> Removed:
>>
>>
>>
>> ################################################################################
>> diff --git a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
>> b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
>> index fa43dae022e89..f08dbeeb8d019 100644
>> --- a/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
>> +++ b/llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
>> @@ -420,6 +420,7 @@ class VSETVLIInfo {
>> };
>>
>> #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
>> +LLVM_ATTRIBUTE_USED
>> inline raw_ostream &operator<<(raw_ostream &OS, const
>> VSETVLIInfo &V) {
>> V.print(OS);
>> return OS;
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220509/e19bf3be/attachment.html>
More information about the llvm-commits
mailing list