[PATCH] D125117: [AMDGPU][GFX10] Support base+soffset+offset SMEM loads.

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added a comment.

The patch looks fine to me.

I'd have added a couple of tests for new addressing mode to validate offset limitations, e.g.

  s_load_dwordx16 s[20:35], s[4:5], s0 offset:0x1FFFFF
  s_buffer_load_dwordx16 s[20:35], s[4:7], s0 offset:-1

should trigger an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125117/new/

https://reviews.llvm.org/D125117