[PATCH] D124565: [mlgo] Support exposing more features than those supported by models

Mon May 9 13:21:35 PDT 2022

yundiqian accepted this revision.
yundiqian added a comment.
This revision is now accepted and ready to land.

In D124565#3486601 <https://reviews.llvm.org/D124565#3486601>, @mtrofin wrote:

> In D124565#3481794 <https://reviews.llvm.org/D124565#3481794>, @yundiqian wrote:
>
>> what restricts that "the new features must be appended at the end of the list of features requested from the model"?
>
> It's a requirement for development mode only (updated to clarify). To your question, see TFUtils.cpp, lines 303 and then the added lines 309 and below.
>
>> Wondering whether it is possible to relax this constraint cause it may cause trouble if there are multiple developers for the same pass
>
> How?

As per offline discussion, will keep this constraint for now, and remove this constraint after migrating to tflite.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124565/new/

https://reviews.llvm.org/D124565