[PATCH] D125248: [instcombine] Propagate freeze back to def

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 11:11:53 PDT 2022


mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3813
+  } else {
+    FrozenMaybePoisonOperand->insertBefore(OrigOpInst);
+  }
----------------
I *think* this is just the case when `MaybePoisonOperand` is a function parameter, so we should insert in the entry block - but want to first make sure the idea of the patch isn't missing something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125248/new/

https://reviews.llvm.org/D125248



More information about the llvm-commits mailing list