[PATCH] D125130: [CodeGen] Clarify the semantics of ADDCARRY/SUBCARRY

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 09:25:52 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:293
+  /// semantcis of these opcodes by inverting the incoming carry/borrow, feeding
+  /// it to the sub/add hardware instruction, and then inverting the outgoing
+  /// carry/borrow.
----------------
Should this be "add/sub" to match the order of "carry/borrow" used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125130/new/

https://reviews.llvm.org/D125130



More information about the llvm-commits mailing list