[PATCH] D124118: [Peephole-Opt] For one kind of test-after-add pattern, eliminates test if it's correct to do so.

Mon May 9 09:01:49 PDT 2022

craig.topper added inline comments.

================
Comment at: llvm/test/CodeGen/X86/peephole-test-after-add.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -o - %s -mtriple=x86_64-unknown-linux-gnu --run-pass=peephole-opt | FileCheck %s
+
----------------
skan wrote:
> skan wrote:
> > Minor suggestion `-o - %s` -> `< %s`
> Never mind. I didn't realize that "< %s" does not work for "--run-pass".
I think it doesn't work for .mir input because llc uses the extension of the file name is used to determine file type. If you use re-direction llc can't see the extension so just assumes .ll.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124118/new/

https://reviews.llvm.org/D124118