[PATCH] D125232: [riscv] Fix data flow for VSETVLI insertion

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:387
-    // and should keep the predecessor.
-    if (isCompatible(Other, /*Strict*/ true))
-      return *this;
----------------
frasercrmck wrote:
> This is the last use of `/*Strict*/ true` - can we follow up on this and get rid of `Strict` entirely, which was always a patch job?
Definitely!  Hadn't noticed that.  Less code is always good.  :)


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:970
 void RISCVInsertVSETVLI::computeIncomingVLVTYPE(const MachineBasicBlock &MBB) {
+
   BlockData &BBInfo = BlockInfo[MBB.getNumber()];
----------------
frasercrmck wrote:
> Unintended new line?
Yep, will remove before landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125232/new/

https://reviews.llvm.org/D125232