[PATCH] D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectWatchBase.py:183
 
+        expected_value = self._maybe_fix_float(step_info.expected_value)
+
----------------
It's been a little while since I've looked in this code, am I reading this right - `expected_value` is the value returned by the debugger?


================
Comment at: cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/float_range_watch/float_range_zero.cpp:2-3
+// Purpose:
+//      Check that \DexExpectWatchValue float_range=0.0 correctly sets float
+//      difference to a very small default value.
+//
----------------
I'm not sure about this feature. What's the benefit of overriding `0.0` rather than just letting it mean zero?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124511/new/

https://reviews.llvm.org/D124511