[PATCH] D123381: [SelectionDAG] Remove duplicate "is scaled" information from gather/scatter SDNodes.

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1352
+/// NOTE: The value of Scale is typically only known to the node owning the
+/// IndexType, with a value of 1 the equivilant of being unscaled.
+enum MemIndexType { SIGNED_SCALED = 0, UNSIGNED_SCALED };
----------------
nit: I think this should be equivalent?


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1361
 
 inline MemIndexType getSignedIndexType(MemIndexType IndexType) {
+  return SIGNED_SCALED;
----------------
Maybe you can kill off these functions `getSignedIndexType` and `getUnsignedIndexType` at least?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123381/new/

https://reviews.llvm.org/D123381