[PATCH] D125212: [GlobalISel] Allow destination patterns having empty outs

[Abinav Puthan Purayil via Phabricator via llvm-commits]

abinavpp added a comment.

In D125212#3500157 <https://reviews.llvm.org/D125212#3500157>, @foad wrote:

> Would it be helpful if the generated matcher actually checked (or maybe asserted) that the discarded defs are unused?

This makes sense if the we don't have predicates that check for the use of the defs; Like in PowerPC:

  def int_ppc_trechkpt : GCCBuiltin<"__builtin_trechkpt">,
        Intrinsic<[llvm_i32_ty], [], []>;
  
  def TRECHKPT : XForm_base_r3xo <31, 1006,
                                  (outs), (ins), "trechkpt." ...
  
  def : Pat<(int_ppc_trechkpt),
            (TRECHKPT)>;

I don't think it would be useful for D125213 <https://reviews.llvm.org/D125213>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125212/new/

https://reviews.llvm.org/D125212