[PATCH] D124560: [llvm-objdump] Symbolize branch targets and basic block addresses based on the bb-address-map when present in the object file.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

One remaining nit from my point of view, but as noted, I haven't attempted to review the disassembly aspects in depth.



================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:229
 
+  When bb-address-map section is present (i.e., object file is built with `-fbasic-block-sections=labels`) labels are retrieved from that section instead.
+
----------------
jhenderson wrote:
> 
Still missing "the" after the "i.e.".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560