[PATCH] D123902: [llvm-objcopy][ObjectYAML][mips] Add MIPS specific ELF section indexes

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 00:29:31 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but please rename the test file as indicated, before landing.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/hexagon-unsupported-on-x86.test:1
-# RUN: yaml2obj %s -o %t
-# RUN: not llvm-objcopy %t %t2 2>&1 >/dev/null | FileCheck %s
+# RUN: yaml2obj %s -o %t -DMACHINE=HEXAGON
+# RUN: not llvm-objcopy %t %t2 2>&1 >/dev/null | FileCheck %s -DINDEX=65280
----------------
If you're adding MIPS to this test, I'd rename it to something like `unsupported-machine-specific-shndx.test`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123902/new/

https://reviews.llvm.org/D123902



More information about the llvm-commits mailing list