[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2
Ting Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 8 21:08:13 PDT 2022
tingwang created this revision.
tingwang added reviewers: bzEq, stefanp, nemanjai, shchenz, jsji, PowerPC.
tingwang added a project: LLVM.
Herald added subscribers: kbarton, hiraditya.
Herald added a project: All.
tingwang requested review of this revision.
Herald added a subscriber: llvm-commits.
https://github.com/llvm/llvm-project/issues/55272 reported an error which appears to be one regression:
The troubled instruction was introduced for both P7 <https://reviews.llvm.org/P7> and A2 as below link shows:
https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20130325/169706.html
However it seems below commit missed the A2 part and introduced the regression:
https://github.com/llvm/llvm-project/commit/fb4e44c4e7daaaa1d2776e76d43566b0db264f30
Referring to below page, it seems A2 should have FeatureISA2_06 in its feature list:
https://en.wikipedia.org/wiki/IBM_A2
Thus I'm proposing this fix. Please help comment, thanks!
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D125203
Files:
llvm/lib/Target/PowerPC/PPC.td
llvm/test/CodeGen/PowerPC/bswap-load-store.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125203.427973.patch
Type: text/x-patch
Size: 3821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220509/751fbd0a/attachment.bin>
More information about the llvm-commits
mailing list