[PATCH] D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 8 19:43:52 PDT 2022


kuhar added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILOpLowering.cpp:150
+    return (Twine(DXILOpNamePrefix) + Twine(getOpCodeClassName(Prop))).str();
+  } else {
+    return (Twine(DXILOpNamePrefix) + Twine(getOpCodeClassName(Prop)) + "." +
----------------
nit: no need for else after return:  https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124805/new/

https://reviews.llvm.org/D124805



More information about the llvm-commits mailing list