[PATCH] D122270: Support converting pointers from opaque to typed

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILWriter/CMakeLists.txt:1
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../)
+
----------------
kuhar wrote:
> Could we use `target_include_directories` instead or a global ones?
`include_directories` sets the directory property not the global one, so it only applies to this directory and any subdirectories. There's no reason we couldn't use the target-specific one, but there is no material difference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122270/new/

https://reviews.llvm.org/D122270