[PATCH] D125181: [BOLT][DWARF] Fix assert for split dwarf.

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 7 18:04:06 PDT 2022


rafauler added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:1021-1028
       } else if (CU->getVersion() >= 5) {
         // A case where we were not using .debug_addr section, but after update
         // now using it.
         const DWARFAbbreviationDeclaration *Abbrev =
             DIE.getAbbreviationDeclarationPtr();
         AbbrevWriter->addAttribute(*CU, Abbrev, dwarf::DW_AT_addr_base,
                                    dwarf::DW_FORM_sec_offset);
----------------
Won't this code be unreachable after the change in 1003?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125181/new/

https://reviews.llvm.org/D125181



More information about the llvm-commits mailing list