[PATCH] D124895: [Object] Fix updating darwin archives

[Keith Smiley via Phabricator via llvm-commits]

keith updated this revision to Diff 427884.
keith marked an inline comment as done.
keith added a comment.

Change test strategy to test for timestamps instead of alignment. This gives us the same result knowing that the darwin specific logic is hit, and it's easier to test for than crafting an unaligned binary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124895/new/

https://reviews.llvm.org/D124895

Files:
  llvm/include/llvm/Object/MachO.h
  llvm/lib/ObjCopy/Archive.cpp
  llvm/lib/ObjCopy/MachO/MachOObjcopy.cpp
  llvm/lib/Object/MachOObjectFile.cpp
  llvm/test/tools/llvm-ar/macho-edit.test
  llvm/test/tools/llvm-objcopy/MachO/archive-format.test
  llvm/tools/llvm-ar/llvm-ar.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124895.427884.patch
Type: text/x-patch
Size: 6790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220507/de635953/attachment-0001.bin>