[PATCH] D125168: Add opaque ptr to the llvm-c

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 7 08:37:09 PDT 2022


deadalnix requested changes to this revision.
deadalnix added a comment.
This revision now requires changes to proceed.

This is lacking a test. The LLVM C API is typically tested using the echo test (a program that read LLVM IR with the LLVM C API, and the re-emit it, and it can be checked that both are equal).



================
Comment at: llvm/include/llvm-c/Core.h:1541
 LLVMTypeRef LLVMX86AMXType(void);
+LLVMTypeRef LLVMPointerType2(unsigned AddressSpace);
 
----------------
Considering that using things without context is deprecated, maybe we can skip this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125168/new/

https://reviews.llvm.org/D125168



More information about the llvm-commits mailing list