[PATCH] D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 7 04:35:23 PDT 2022


pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4102
       // Some targets don't have a powi libcall; use pow instead.
       SDValue Exponent = DAG.getNode(ISD::SINT_TO_FP, SDLoc(Node),
                                      Node->getValueType(0),
----------------
xiangzhangllvm wrote:
> pengfei wrote:
> > We should generate `STRICT_SINT_TO_FP` and `STRICT_FPOWI` for strict node and push the output chain into `Results`.
> Here is already STRICT_FPOWI, and the Target has no libcall for STRICT_FPOWI
Oh, I meant `STRICT_FPOW`...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125159/new/

https://reviews.llvm.org/D125159



More information about the llvm-commits mailing list