[PATCH] D125072: [MachineOutliner] Make getOutliningType partially target-independent

[Wang Pengcheng via Phabricator via llvm-commits]

pcwang-thead added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1944
+public:
+  /// Returns how or if \p MI should be outlined.
+  outliner::InstrType
----------------
We may need to change `\p MI` to `\p MIT` or modify param name.


================
Comment at: llvm/lib/CodeGen/TargetInstrInfo.cpp:1458
+  // This includes MachineBasicBlock references, BlockAddressses,
+  // Constant pool indices, jump table indices, and frame indices.
+  //
----------------
"frame indices" could be excluded since we assert them now. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125072/new/

https://reviews.llvm.org/D125072