[PATCH] D125145: [Bitstream] Only consider flushing to file on block boundaries

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 16:42:52 PDT 2022


sammccall added a comment.

This seems safe unless the ldd/LTO/bitcode case that motivated this flushing can have huge amounts of data (comparable to buffer size) with no subblocks.
Staring at the code, that seemed unlikely but I'm not familiar with what goes into these files. @stephan.yichao.zhao @MaskRay any thoughts?

(This isn't terribly important, so if it's not obvious I can just drop it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125145/new/

https://reviews.llvm.org/D125145



More information about the llvm-commits mailing list