[PATCH] D123089: BuildLibCalls: infer allockind attributes on relevant functions

Fri May 6 14:40:01 PDT 2022

durin42 marked an inline comment as done.
durin42 added inline comments.

================
Comment at: llvm/test/Transforms/InferFunctionAttrs/annotate.ll:223

-; CHECK: declare noalias noundef i8* @aligned_alloc(i64 allocalign noundef, i64 noundef) [[INACCESSIBLEMEMONLY_NOFREE_NOUNWIND_WILLRETURN_ALLOCSIZE1_FAMILY_MALLOC:#[0-9]+]]
+; CHECK: declare noalias noundef i8* @aligned_alloc(i64 allocalign noundef, i64 noundef) [[INACCESSIBLEMEMONLY_NOFREE_NOUNWIND_WILLRETURN_ALLOCKIND18_ALLOCSIZE1_FAMILY_MALLOC:#[0-9]+]]
 declare i8* @aligned_alloc(i64, i64)
----------------
nikic wrote:
> What do these ALLOCKIND18 etc names stand for? Is that the integral value of the flags?
Yeah, in a past version of this I hadn't come up with the hack to parse a string in the text IR, so they were integers. I've updated the values to have more meaningful names, even if they're verbose.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123089/new/

https://reviews.llvm.org/D123089