[PATCH] D125130: [CodeGen] Clarify the semantics of ADDCARRY/SUBCARRY

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 14:17:49 PDT 2022


efriedma added a comment.

I don't think most people are going to be familiar with "active high"/"active low" terminology.  At least, I had to look it up.

I think it makes sense to:

1. Explicitly mention the relationship with UADDO/USUBO.
2. Explicitly call out that for subtraction, the native carry flag is the inverse of what USUBO produces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125130/new/

https://reviews.llvm.org/D125130



More information about the llvm-commits mailing list