[PATCH] D125114: [SimplifyLibCalls] handle subobjects of constant aggregates

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 13:14:19 PDT 2022


nikic added a comment.

In D125114#3497477 <https://reviews.llvm.org/D125114#3497477>, @nikic wrote:

> Now that the ConstantDataArraySlice no longer corresponds to an already existing ConstantDataArray, it should probably be switched to store an array of bytes instead. From a cursory look, I don't think anything fundamentally depends on the current representation.

Hm, I guess the need to represent slices of different element types could make things somewhat awkward. ConstantDataArray represents everything as an array of bytes internally, and then type-puns to the actual element type on access.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125114/new/

https://reviews.llvm.org/D125114



More information about the llvm-commits mailing list