[PATCH] D123678: [polly] migrate -polly-show to the new pass manager

Fri May 6 10:37:57 PDT 2022

YangKeao marked 2 inline comments as done.
YangKeao added inline comments.

================
Comment at: polly/include/polly/ScopGraphPrinter.h:33
+template <>
+struct GraphTraits<ScopDetection> : public GraphTraits<RegionInfo *> {
+  static NodeRef getEntryNode(const ScopDetection &SD) {
----------------
Meinersbur wrote:
> Looking at other specializations, all GraphTraits of an analysis are a pointer of the the analysis (`GraphTraits<ScopDetection>`). Why the change? I fear that GraphTraits users may accidentally try to copy the object.
> Why the change?

Because we could get the reference to `ScopDetection` from `FAM.getResult`, and it's quite straightforward to pass the reference to everywhere.

> I fear that GraphTraits users may accidentally try to copy the object.

When will it happen? The arguments of the functions are all passing through reference.

But as I'm not familiar with `GraphTraits` and its other usage, I think it's fine not to touch it in this commit. I will use `GraphTraits<ScopDetection *>` instead.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123678/new/

https://reviews.llvm.org/D123678