[PATCH] D124697: Distinguish between different forms of "address-taken" MachineBasicBlocks

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 10:37:45 PDT 2022


kparzysz added a comment.

I'm not questioning the splitting, I'm just wondering if the terminology could be more self-explanatory.  In AsmPrinter there is a check that an address-taken block must actually be present, but that's a hard requirement really only when there is a branch to it.  So I was thinking that maybe "isIndirectBranchTarget" could be a better name, but I wasn't sure if it captures the intent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124697/new/

https://reviews.llvm.org/D124697



More information about the llvm-commits mailing list