[PATCH] D125009: [ArgPromotion] Use common alignment for loads in caller

Pavel Samolysov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 09:23:58 PDT 2022


psamolysov added a comment.

In D125009#3496960 <https://reviews.llvm.org/D125009#3496960>, @jdoerfert wrote:

>> I though this is illegal to use align 4 loads for align 32 arguments.
>
> It is not. Any lower alignment (for the load) is perfectly legal.

@jdoerfert thank you for the answer.
If so, I see no sense for these changes and the revision can be abandoned. >From another point of view, this is an opportunity from the optimization perspective to use for the promoted 'load' instructions the alignment from the argument's allocation if this won't make the code of the pass significant harder but as @nikic has already mentioned, this pass looks as it's not the right place to do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125009/new/

https://reviews.llvm.org/D125009



More information about the llvm-commits mailing list