[PATCH] D124908: [SVE] Optimize new cases for lowerConvertToSVBool

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4177
+    unsigned IntNo = InOp.getConstantOperandVal(0);
+    switch (IntNo) {
+    case Intrinsic::aarch64_sve_ptrue:
----------------
Can you use `InOp.getConstantOperandVal(0)` directly here? because otherwise the next person to add an entry is going to get compiler warnings about the liveness of `IntNo` crossing case boundaries.  You could fix this by adding extra {} but given this is the only use of `IntNo` there doesn't seem much value in keeping it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124908/new/

https://reviews.llvm.org/D124908