[PATCH] D118426: [InstCombine] Remove side effect of replaced constrained intrinsics

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.

LGTM w/suggest comment change applied.



================
Comment at: llvm/include/llvm/Analysis/InstructionSimplify.h:307
+///
+/// Constrained FP intrinsic may be declared as having side effect. This
+/// function may simplify its call into a value without side effect if it is
----------------
Suggested wording change:

Unlike other SimplifyX routines, this function provides an additional contract.  Specifically, it guarantees that if simplification succeeds that the intrinsic is side effect free.  As a result, successful simplification can be used to delete the intrinsic not just replace its result.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118426/new/

https://reviews.llvm.org/D118426