[PATCH] D125071: [InstCombine] Baseline tests for InstCombine optimization to merge GEP instructions with constant indices

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 02:55:31 PDT 2022


nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/gep-merge-constant-indices.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=instcombine -opaque-pointers -S | FileCheck %s
+
----------------
If this is testing opaque pointers, it would be good if the input IR also used opaque pointers. Mixing both is a bit confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125071/new/

https://reviews.llvm.org/D125071



More information about the llvm-commits mailing list