[PATCH] D125036: [LLD][RISCV] Alignment relaxation

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 01:09:00 PDT 2022


arichardson added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:198
+  {
+    uint64_t removedBytes = 0;
+    const auto *r = ranges.begin(), *rend = ranges.end();
----------------
Missing test coverage, you should add some symbols to your test cases.


================
Comment at: lld/ELF/InputSection.h:249
   mutable ArrayRef<uint8_t> rawData;
+  mutable bool copiedData;
 
----------------
Moving this after the other bool above should avoid the size change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125036/new/

https://reviews.llvm.org/D125036



More information about the llvm-commits mailing list