[PATCH] D125041: [GlobalISel] Combine G_SHL, G_ASHR, G_SHL of undef shifts to undef.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 13:59:40 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-undef.mir:60
     ; CHECK: [[C:%[0-9]+]]:_(s32) = G_CONSTANT i32 0
-    ; CHECK: $w0 = COPY [[C]](s32)
-    ; CHECK: RET_ReallyLR implicit $w0
----------------
Should pre-regenerate these checks to include -NEXT


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-undef.mir:281
+
+...
----------------
Should also test undef lhs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125041/new/

https://reviews.llvm.org/D125041



More information about the llvm-commits mailing list