[PATCH] D124892: [DWARF] Fix split dwarf debug inlining in mix mode situation.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 5 13:03:43 PDT 2022
dblaikie added a comment.
Yeah, mutating the `DICompileUnit` at this point seems a bad idea - it could end up inconsistent between things that happened before the mutation V after, etc.
Also the testing isn't suitable - LLVM tests can't depend on clang and the two IR files could be linked & the single IR result could be the test case? (it should just run llvm-mc - check other debug info tests). With the simplified/linked test, I can take a look and see if I can understand what's broken/how it might be suitable to fix it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124892/new/
https://reviews.llvm.org/D124892
More information about the llvm-commits
mailing list